| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, amitdkhan(dot)pg(at)gmail(dot)com |
| Subject: | Re: partition routing layering in nodeModifyTable.c |
| Date: | 2019-08-09 01:51:49 |
| Message-ID: | CA+HiwqGkhBPCHhB5ZQVKYvSB9kSJRwZt1hnxoKEv+t_SUSknTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujita-san,
On Thu, Aug 8, 2019 at 9:49 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Thu, Aug 8, 2019 at 10:10 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Attached updated patches; only 0001 changed in this version.
>
> Thanks for the updated version, Amit-san! I updated the 0001 patch a
> bit further:
>
> * Tweaked comments in plannodes.h, createplan.c, and nodeForeignscan.c.
> * Made cosmetic changes to postgres_fdw.c.
> * Adjusted doc changes a bit, mainly not to produce unnecessary diff.
> * Modified the commit message.
>
> Attached is an updated version of the 0001 patch. Does that make sense?
Looks perfect, thank you.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-09 02:15:30 | Re: Refactoring code stripping trailing \n and \r from strings |
| Previous Message | Bruce Momjian | 2019-08-09 01:25:22 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |