Re: More speedups for tuple deformation

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, John Naylor <johncnaylorls(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More speedups for tuple deformation
Date: 2026-02-24 08:45:48
Message-ID: CA+HiwqGUXF_iwCHZepH7vM=AZCwDdeesQzwd=OO3i1=F-KouPA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi David,

On Tue, Feb 24, 2026 at 11:23 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I've attached an updated version of the patch (v9).

I noticed what looks like some rebase noise in TupleDescFinalize():

off = att_nominal_alignby(off, cattr->attalignby);

/*
* attcacheoff is an int16, so don't try and cache any offsets larger
* than will fit in that type.
*/
if (off > PG_INT16_MAX)
break;

cattr->attcacheoff = off;

/*
* attcacheoff is an int16, so don't try and cache any offsets larger
* than will fit in that type.
*/
if (off > PG_INT16_MAX)
break;

cattr->attcacheoff = off;

--
Thanks, Amit Langote

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2026-02-24 09:09:54 Re: MERGE behavior with REPEATABLE READ isolation level
Previous Message Chao Li 2026-02-24 08:39:27 Re: Add errdetail() with PID and UID about source of termination signal