| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_overexplain produces invalid JSON with RANGE_TABLE option |
| Date: | 2026-04-16 05:17:08 |
| Message-ID: | CA+HiwqGLK2QzHFZcwJ-+CbNy7BFB2=G_Ce0eSfPzCOGg6+=USw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 16, 2026 at 9:06 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Apr 16, 2026 at 6:36 AM SATYANARAYANA NARLAPURAM
> <satyanarlapuram(at)gmail(dot)com> wrote:
> >
> > Hi Hackers,
> >
> > It appears that pg_overexplain produces invalid JSON output when
> > EXPLAIN (FORMAT JSON, RANGE_TABLE) is used. The "Unprunable RTIs" and
> > "Result RTIs" properties are emitted as key:value pairs directly inside
> > the "Range Table" JSON array, which is structurally invalid.
>
> Thanks for the report and the patch. That makes sense.
>
> > Attempted to fix this by moving ExplainCloseGroup() before the two overexplain_bitmapset()
> > calls, so the properties are emitted as siblings of "Range Table" in the parent object rather
> > than inside the array.
> >
> > Attached a patch to address this which also includes a test.
>
> I have added a commit message. Will commit shortly to master and v18.
Pushed.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-04-16 05:17:22 | Re: [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow() |
| Previous Message | Bharath Rupireddy | 2026-04-16 05:03:33 | Re: Introduce XID age based replication slot invalidation |