From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgbench - allow to create partitioned tables |
Date: | 2019-09-18 06:46:12 |
Message-ID: | CA+HiwqGKW0UJy5QyK64bMxHJCCuzu=qefC_Ftg9dd5ODDyrphA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Fabien,
On Wed, Sep 18, 2019 at 3:49 AM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> Attached v9:
Thanks. This seems to work well.
Couple of nitpicks on parameter error messages.
+ fprintf(stderr, "invalid partition type,
expecting \"range\" or \"hash\","
How about "partitioning method" instead of "partition type"?
+ fprintf(stderr, "--partition-method requires actual
partitioning with --partitions\n");
Assuming that this error message is to direct the user to fix a
mistake they might have inadvertently made in specifying --partitions,
I don't think the message is very clear. How about:
"--partition-method requires --partitions to be greater than zero"
but this wording might suggest to some users that some partitioning
methods do allow zero partitions. So, maybe:
"specifying --partition-method requires --partitions to be greater than zero"
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Smith, Peter | 2019-09-18 06:46:24 | Proposal: Add more compile-time asserts to expose inconsistencies. |
Previous Message | David Fetter | 2019-09-18 06:26:35 | Re: Efficient output for integer types |