Re: ReadRecentBuffer() doesn't scale well

Hi Andres,

On Thu, Oct 9, 2025 at 2:15 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2025-10-08 13:39:14 +1300, Thomas Munro wrote:
> > On Fri, Sep 19, 2025 at 11:44 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > On Fri, Sep 19, 2025 at 12:36 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > > I'm planning to commit 0001 soon, unless you'd like to do the honors - I would
> > > > break it with some upcoming patches, and it's a good improvement. Those
> > > > patches also will PinBuffer_Locked() a bit slower, i.e. it'd be good to avoid
> > > > using it in ReadRecentBuffer() for that reason alone.
> > >
> > > Oh, thanks for thinking about that interaction. I'll go ahead and
> > > push it later today after I re-convince myself that it's correct.
> >
> > Sorry I haven't got to this yet. Please feel free to go ahead and
> > push it if it's blocking you...
>
> Done after two small changes:

Perhaps you are on it, but it seems skink is red due to either this or
one of the other bufmgr changes. I noticed it after I pushed a patch
of mine and couldn't see the connection.

postmaster.log suggests a valgrind error.

--
Thanks, Amit Langote