Re: partition routing layering in nodeModifyTable.c

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: partition routing layering in nodeModifyTable.c
Date: 2020-10-09 08:01:39
Message-ID: CA+HiwqGEmiib8FLiHMhKB+CH5dRgHSLc5N5wnvc4kym+ZYpQEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 8, 2020 at 9:35 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Oct 7, 2020 at 9:07 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> > On 07/10/2020 12:50, Amit Langote wrote:
> > > I have thought about something like this before. An idea I had is to
> > > make es_result_relations array indexable by plain RT indexes, then we
> > > don't need to maintain separate indexes that we do today for result
> > > relations.
> >
> > That sounds like a good idea. es_result_relations is currently an array
> > of ResultRelInfos, so that would leave a lot of unfilled structs in the
> > array. But in on of your other threads, you proposed turning
> > es_result_relations into an array of pointers anyway
> > (https://www.postgresql.org/message-id/CA+HiwqE4k1Q2TLmCAvekw+8_NXepbnfUOamOeX=KpHRDTfSKxA@mail.gmail.com).
>
> Okay, I am reorganizing the patches around that idea and will post an
> update soon.

Attached updated patches.

0001 makes es_result_relations an RTI-indexable array, which allows to
get rid of all "result relation index" fields across the code.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v13-0001-Make-es_result_relations-array-indexable-by-RT-i.patch application/octet-stream 27.7 KB
v13-0002-Include-result-relation-index-if-any-in-ForeignS.patch application/octet-stream 11.6 KB
v13-0005-Revise-child-to-root-tuple-conversion-map-manage.patch application/octet-stream 21.9 KB
v13-0004-Rearrange-partition-update-row-movement-code-a-b.patch application/octet-stream 16.0 KB
v13-0003-Remove-es_result_relation_info.patch application/octet-stream 39.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Nancarrow 2020-10-09 08:06:33 Re: Parallel copy
Previous Message Peter Eisentraut 2020-10-09 07:31:33 Re: dynamic result sets support in extended query protocol