Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: feichanghong(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Date: 2025-09-18 01:33:37
Message-ID: CA+HiwqG7Heq9WuzwtNixdqYEOAgcEgmx7dQGkGE0Bwt3v0EBXw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Sep 18, 2025 at 7:32 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Thu, 18 Sept 2025 at 09:43, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > The first bad commit is:
> >
> > commit bb3ec16e14ded1d23a46d3c7e623a965164fa124
> > Author: Amit Langote <amitlan(at)postgresql(dot)org>
> > Date: Thu Jan 30 11:57:32 2025 +0900
> >
> > Move PartitionPruneInfo out of plan nodes into PlannedStmt
>
> I think the attached is the correct fix. I also wonder if it's worth
> an isolation test to exercise this code.

Thanks for the patch, David, and for the report, Fei. I indeed forgot
to update EvalPlanQualStart() in that commit.

I agree about adding an isolation test, which I have done in the
attached updated patch.

--
Thanks, Amit Langote

Attachment Content-Type Size
v2-0001-Fix-EPQ-crash-from-missing-partition-pruning-stat.patch application/octet-stream 4.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message feichanghong 2025-09-18 01:58:29 Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Previous Message Michael Paquier 2025-09-18 00:24:49 Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c