| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor attribute mappings used in logical tuple conversion |
| Date: | 2019-12-19 01:23:32 |
| Message-ID: | CA+HiwqFrHa=1Okqj3Oao1itSRoarUXd3N01vJ9wXC8w2zi-_QA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Dec 18, 2019 at 11:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> TBH, though, I wonder if this doesn't indicate you've put this
> function in the wrong header to begin with. Why does it belong
> in rewriteManip?
Assuming you are talking about map_variable_attnos(), it's always been
in rewriteManip.c / rewriteManip.h since it was added by 541ffa65c32.
While reviewing this patch, I had the idea of moving it to the new
header attmap.h, but thought it might be a good idea to keep attmap.c
limited to just building the maps and not move into it other functions
that do something useful with those maps, like translating expression
trees, converting tuples, etc.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-19 01:38:08 | Re: pgsql: Refactor attribute mappings used in logical tuple conversion |
| Previous Message | Robert Haas | 2019-12-18 18:11:00 | Re: pgsql: Partially deduplicate interrupt handling for background processe |