From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Pavel Biryukov <79166341370(at)yandex(dot)ru> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: posgres 12 bug (partitioned table) |
Date: | 2020-10-28 14:01:16 |
Message-ID: | CA+HiwqFjEim_RMCiaFxA4nUx00o3auXKPy-OsOcog+chg5K-zA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Tue, Oct 27, 2020 at 10:55 PM Pavel Biryukov <79166341370(at)yandex(dot)ru> wrote:
>
> Hi!
>
> What's the state with this issue?
I think that the patch that Andres Freund posted earlier on this
thread [1] would be fine as a workaround at least for stable releases
v12 and v13. I have attached with this email a rebased version of
that patch, although I also made a few changes. The idea of the patch
is to allocate and use a partition-specific *non-virtual* slot, one
that is capable of providing system columns when the RETURNING
projection needs them. Andres' patch would allocate such a slot even
if RETURNING contained no system columns, whereas I changed the slot
creation code stanza to also check that RETURNING indeed contains
system columns. I've attached 2 patch files: one for HEAD and another
for v12 and v13 branches.
That said, the discussion on what to do going forward to *cleanly*
support accessing system columns through partitioned tables is
pending, but maybe the "workaround" fix will be enough in the meantime
(at least v12 and v13 can only get a workaround fix).
--
Amit Langote
EDB: http://www.enterprisedb.com
[1] https://www.postgresql.org/message-id/20200811180629.zx57llliqcmcgfyr%40alap3.anarazel.de
Attachment | Content-Type | Size |
---|---|---|
parted-insert-returning_syscols_HEAD_v2.patch | application/octet-stream | 5.6 KB |
parted-insert-returning_syscols_BACKPATCH_v2.patch | application/octet-stream | 5.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-28 18:39:39 | Re: BUG #16688: psql removes only LF without CR at end of backquotes on windows. |
Previous Message | Tom Lane | 2020-10-28 13:59:24 | Re: BUG #16577: Segfault on altering a table located in a dropped tablespace |
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2020-10-28 14:16:26 | cleanup temporary files after crash |
Previous Message | Bharath Rupireddy | 2020-10-28 13:49:55 | Re: A new function to wait for the backend exit after termination |