| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Lucas Jeffrey <lucas(dot)jeffrey(at)anachronics(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Trakshan Mishra <trakshanmishra477(at)gmail(dot)com>, Andrés Krüger <andres(dot)kruger(at)anachronics(dot)com>, Rodolfo Campero <rodolfo(dot)campero(at)anachronics(dot)com> |
| Subject: | Re: Re: [PATCH] Fix segmentation fault caused by reentrancy in RI_Fkey_cascade_del (ri_triggers.c) |
| Date: | 2026-10-24 07:01:42 |
| Message-ID: | CA+HiwqFCw_Lqrs8RrkBSN5hHNSA3wVSdmbh+8vgQLK8Sc90djQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 23, 2026 at 10:26 PM Lucas Jeffrey <
lucas(dot)jeffrey(at)anachronics(dot)com> wrote:
> Hi Amit,
>
> Thanks for v10, and for the credit in the commit message.
>
> I tested v10 on master and on REL_14 through REL_19, built with
> cassert, and make check passes on all of them, including the new
> tests in foreign_key. It addresses everything we found, so it LGTM.
>
> I found just one small thing, non-locking: the new test comment in
> foreign_key.sql (and in foreign_key.out) says "(an assertion at end
> of transaction checks that)", but that assertion was removed in v10,
> so I would remove that part of the comment before commiting
> (doesn't needs a v11).
Thanks for reporting that. Will fix.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2026-10-24 08:06:27 | Self-join elimination discards differing row lock wait policies |
| Previous Message | Amit Kapila | 2026-10-24 06:11:55 | Re: Proposal: Conflict log history table for Logical Replication |