| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | jie wang <jugierwang(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Evan Montgomery-Recht <montge(at)mianetworks(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Eliminating SPI / SQL from some RI triggers - take 3 |
| Date: | 2026-04-09 09:24:47 |
| Message-ID: | CA+HiwqFAYnp24x_-+5tSOcn1k5uxRkcHPDbThhhuR2K4qk1oMg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 9, 2026 at 6:22 PM jie wang <jugierwang(at)gmail(dot)com> wrote:
> Hi,
>
> I took a glance at the patch, overall looks good to me. A nitpick on 0001:
>
> + bool firing_batch_callbacks; /* true when in
> + * FireAfterTriggersBatchCallbacks() */
>
> Looks like a typo in the comment. The function name is FireAfterTriggerBatchCallbacks, no “s” after Trigger.
Thanks, I've fixed the typo in my local tree.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-04-09 09:26:29 | Re: Adding REPACK [concurrently] |
| Previous Message | jie wang | 2026-04-09 09:21:51 | Re: Eliminating SPI / SQL from some RI triggers - take 3 |