| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: ExecRTCheckPerms() and many prunable partitions (checkAsUser) |
| Date: | 2023-02-21 07:12:14 |
| Message-ID: | CA+HiwqF3P2_kQCx4GRc+3W9w0+dTLByT9P0AB5fivmWP0ObLCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 21, 2023 at 12:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > On 2023-Feb-20, Amit Langote wrote:
> >> One more thing we could try is come up with a postgres_fdw test case,
> >> because it uses the RelOptInfo.userid value for remote-costs-based
> >> path size estimation. But adding a test case to contrib module's
> >> suite test a core planner change might seem strange, ;-).
>
> > Maybe. Perhaps adding it in a separate file there is okay?
>
> There is plenty of stuff in contrib module tests that is really
> there to test core-code behavior. (You could indeed argue that
> *all* of contrib is there for that purpose.) If it's not
> convenient to test something without an extension, just do it
> and don't sweat about that.
OK. Attached adds a test case to postgres_fdw's suite. You can see
that it fails without a316a3bc.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-postgres_fdw-test-userid-propagation-to-rels-unde.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2023-02-21 07:23:26 | Re: Authentication fails for md5 connections if ~/.postgresql/postgresql.{crt and key} exist |
| Previous Message | Peter Smith | 2023-02-21 07:11:06 | Re: [Proposal] Add foreign-server health checks infrastructure |