From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: pg_trigger.tgparentid |
Date: | 2020-02-25 01:26:19 |
Message-ID: | CA+HiwqF30bLyyxwUKGhTUwySACAioUTy2tUXfbh5-4_668XFdA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Alvaro,
On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> On 2020-Feb-19, Amit Langote wrote:
>
> > Or:
> >
> > * However, if our parent is a partition itself, there might be
> > * internal triggers that must not be skipped. For example, triggers
> > * on the parent that were in turn cloned from its own parent are
> > * marked internal, which must be cloned to the partition.
>
> Thanks for pointing this out -- I agree it needed rewording. I slightly
> adjusted your text like this:
>
> * Internal triggers require careful examination. Ideally, we don't
> * clone them. However, if our parent is itself a partition, there
> * might be internal triggers that must not be skipped; for example,
> * triggers on our parent that are in turn clones from its parent (our
> * grandparent) are marked internal, yet they are to be cloned.
>
> Is this okay for you?
Thanks. Your revised text looks good, except there is a typo:
in turn clones -> in turn cloned
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2020-02-25 01:55:09 | Re: Internal key management system |
Previous Message | Kyotaro Horiguchi | 2020-02-25 01:14:10 | Re: False failure during repeated windows build. |