Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: feichanghong <feichanghong(at)qq(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Date: 2025-09-18 08:25:28
Message-ID: CA+HiwqF2jPPZL1Kj-qo=pTnjKE_As-JvTvy8zMj0qEu+Gc=HaA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Sep 18, 2025 at 4:06 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 18 Sept 2025 at 18:20, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Oops, coffee deficiency. Updated again.
>
> Thanks for updating the patch.
>
> I think the original intent of "Parsed test spec with 3 sessions"
> (from 759d9d676) was two sessions doing work, and an independent
> observer session. Is there a reason to add 2 more sessions? Maybe it's
> me not working with the isolation tester often enough, but I'd have
> expected you to add steps for s1 and s2 then define permutations for
> those steps.

Yeah, that makes the additions smaller and avoids slowing down the
suite. It did take a bit of fiddling though -- after switching to use
the existing sessions, teardown in s1 hung because I hadn’t noticed
that s2’s setup already does a BEGIN, so the delete side ended up
without a COMMIT, leaving an open transaction that blocked DROP in
s1’s teardown. Easier to take shortcuts with new sessions like I
first did, but better to keep the suite light. :-)

Done in the attached.

--
Thanks, Amit Langote

Attachment Content-Type Size
v6-0001-Fix-EPQ-crash-from-missing-partition-pruning-stat.patch application/octet-stream 4.1 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Алена Васильева 2025-09-18 08:44:57 PATCH for BUG #18785: Pointer bmr.rel, dereferenced by passing as 1st parameter to function is checked for NULL later
Previous Message David Rowley 2025-09-18 07:05:55 Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos