From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: Change ereport level for QueuePartitionConstraintValidation |
Date: | 2019-07-16 02:40:22 |
Message-ID: | CA+HiwqEuaAtfW1u5+5M0X9m5DPdooqC=TgGDJ-ALN1-==JKy4g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jul 16, 2019 at 10:15 AM David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On Tue, 16 Jul 2019 at 03:13, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > I vote for changing it to NOTICE instead of DEBUG1.
>
> Well, there are certainly other DDL commands that spit out NOTICES.
>
> postgres=# create table z (a int);
> CREATE TABLE
> postgres=# create table x (a int) inherits(z);
> NOTICE: merging column "a" with inherited definition
> CREATE TABLE
>
> However, we did get rid of a few of those a while back. In 9.2 we used to have:
>
> postgres=# create table a (a int primary key);
> NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index
> "a_pkey" for table "a"
>
> I'm pretty keen for consistency. Having ATTACH PARTITION spit out an
> INFO and merge attributes a NOTICE, and SET NOT NULL just a DEBUG1 is
> pretty far from consistent. I wouldn't object to making them all
> NOTICE. I've only seen complaints about the INFO one.
Fwiw, I'm leaning toward NOTICE for all. It's helpful for users to
know a certain action was taken.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2019-07-16 02:56:46 | Re: POC: converting Lists into arrays |
Previous Message | Tom Lane | 2019-07-16 01:26:07 | Re: Change ereport level for QueuePartitionConstraintValidation |