From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: makeAndExpr(), etc. confined to gram.y? |
Date: | 2014-06-25 23:29:39 |
Message-ID: | CA+HiwqEj926DgrxQ7g1Xik9mzd1uqOZja9GTZxMrBOdLmcqsRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 26, 2014 at 12:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Langote <amitlangote09(at)gmail(dot)com> writes:
>> Yeah, that is true. Sorry, I am unaware as to how generic make*
>> functions in gram.y are and how they differ from those in makefuncs.c.
>
>> So, use of make* family of functions outside parser is their abuse in
>> some way? Anything that needs to use these functions should somehow be
>> accomplished in parser perhaps. For example, duplicate/redundant CHECK
>> expressions elimination and such?
>
> Well, the larger point here is that those functions are specific to
> gram.y's problem of constructing multi-AND(OR) structures during a series
> of binary production actions. I don't see that there's any use for them
> elsewhere, and the way that they modify the input structures wouldn't
> necessarily be safe anywhere else either.
>
I see. Thanks for clarifying.
--
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-06-26 00:16:08 | Re: better atomics - v0.5 |
Previous Message | John Lumby | 2014-06-25 23:05:53 | Re: Extended Prefetching using Asynchronous IO - proposal and patch |