Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tender Wang <tndrwang(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error
Date: 2026-01-14 13:38:29
Message-ID: CA+HiwqEigoxJN-nTkxDEQxzzK+KW5QmF5yU7xQ5DRS9dO-_4Dw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Jan 14, 2026 at 9:30 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Attached is an updated version with improved comments and simplified test cases.
>
> Regarding back-patch safety (to v14 where the bug was introduced):
>
> * EXPLAIN VERBOSE output order changes (ctid now appears before tableoid)
> * AddForeignUpdateTargets is no longer called when the FDW doesn't
> support the command

Hit send too soon re the 2nd bit I guess. Actually we can just return
false when AddForeignUpdateTargets is missing, so the callback is
still called when present.

Updated patch attached.

--
Thanks, Amit Langote

Attachment Content-Type Size
v4-0001-Fix-row-identity-handling-for-dummy-partitioned-r.patch application/octet-stream 40.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2026-01-14 16:45:30 Re: BUG #19366: heap-use-after-free in pgaio_io_reclaim() detected with RELCACHE_FORCE_RELEASE
Previous Message Amit Langote 2026-01-14 12:30:37 Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error