Re: logical/relation.c header description

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical/relation.c header description
Date: 2020-09-17 13:16:43
Message-ID: CA+HiwqEdiiF9UP58MBOmjM=qr_kG0zvRQ32JPrPVUTLo9_FgTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for taking a look.

On Thu, Sep 17, 2020 at 9:20 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Sep 17, 2020 at 3:22 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
>
> /*-------------------------------------------------------------------------
> * relation.c
> - * PostgreSQL logical replication
> + * PostgreSQL logical replication relation mapping routines
> *
> ..
> * NOTES
> * This file contains helper functions for logical replication relation
> * mapping cache.
>
> The new header title and NOTES section say the almost same thing. How
> about changing the title as "PostgreSQL logical replication relation
> mapping cache" and remove the NOTES section.

That makes sense.

Actually, I did consider expanding that NOTE to mention what the
module does but there are not actually that many interesting things in
there. If you would like to take a look at the text I had come up
with, please check the attached.

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
logicalrep-file-header-desc_v2.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2020-09-17 13:18:55 Re: Parallelize stream replication process
Previous Message k.jamison@fujitsu.com 2020-09-17 13:06:33 RE: [Patch] Optimize dropping of relation buffers using dlist