| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: assert pg_class.relnatts is consistent |
| Date: | 2020-02-14 09:00:05 |
| Message-ID: | CA+HiwqERtqJPhn_ByRJs3jE6wmhjRPcVg7fvNkCHYpQpHomGUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 14, 2020 at 2:58 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Fri, Feb 14, 2020 at 1:04 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I've been burnt by this too :-(. However, I think this patch is
> > completely the wrong way to go about improving this. What we should
> > be doing, now that we have all that perl code generating postgres.bki,
> > is eliminating the problem at the source. That is, drop the hand-coded
> > relnatts values from pg_class.dat altogether, and let the perl code fill
> > it in --- compare the handling of pg_proc.pronargs for instance.
>
> I can't write Perl myself (maybe Justin), but +1 to this idea.
I tried and think it works but not sure if that's good Perl
programming. See the attached.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-require-relnatts-to-be-specified-in-pg_class.d.patch | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-02-14 09:15:27 | Re: Fix compiler warnings on 64-bit Windows |
| Previous Message | Kyotaro Horiguchi | 2020-02-14 08:29:54 | Re: pgsql: walreceiver uses a temporary replication slot by default |