Re: pgsql: Invalidate RI fast-path metadata on operator family changes

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org, pgsql-release(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Invalidate RI fast-path metadata on operator family changes
Date: 2026-09-21 01:04:56
Message-ID: CA+HiwqEGMLYUaUjXO6sGB1Xf2XUaj6aGtBaiZxW1TjZDS-z-3Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Sep 20, 2026 at 14:20 Amit Langote <amitlangote09(at)gmail(dot)com> wrote:

> On Sun, Sep 20, 2026 at 1:20 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> > > Added pgsql-release. For context: the change is regression-test-only.
> > > It wraps the operator-family test added by c62b330912e in a
> > > rolled-back transaction so the family is never visible to concurrently
> > > running tests, which has been causing intermittent plan-shape failures
> > > in window.sql and equivclass.sql on several buildfarm animals (six in
> > > the last ~24h as Tom noted).
> > > Patch I would like to push is attached. I'd like concurrence to push
> > > it to REL_19_STABLE during the freeze.
> >
> > To add to that: we've got about 40 hours before the 19beta4 wrap.
> > Given that these buildfarm failures are intermittent, that's already
> > not enough time to be 100% sure that the patch fixes them --- I think
> > it will, but perhaps not. However, the worst-case outcome is that
> > this makes things visibly worse, in which case we could revert it
> > sometime Monday and be no worse off than we are now. So my vote is
> > to go ahead, and not be too slow about that.
>
> OK, I've pushed to both master and 19.

16 hours in and no new reds so far, so the fix seems to have worked.

- Amit

>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-09-21 10:21:30 pgsql: Translation updates
Previous Message Amit Langote 2026-09-20 05:20:51 Re: pgsql: Invalidate RI fast-path metadata on operator family changes