Re: PG19: two RI fast-path issues found while testing the batching revert

On Fri, Sep 18, 2026 at 6:21 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Sep 17, 2026 at 8:00 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > On Thu, Sep 17, 2026 at 0:41 Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
> >> On Tue, Sep 15, 2026 at 11:12 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >> > Thanks for the report and the patch.
> >> >
> >> > I've added an open item:
> >> >
> >> > RI fastpath misses pg_amop updates
> >> > Commit: 2da86c1ef9b
> >> > Owner: Amit Langote
> >>
> >> Will the fix be something like what Nikolay proposed or something
> >> different that solves both the issue in the fast path and the
> >> pre-existing issue with the cached cast functions?
> >
> >
> > There’s some overlap but I’m planning to fix the cast issue separately, that is, not combine it with the fix for this open item which I’d like to fix by beta4 freeze.
>
> Attached are the patches for fixing the two open items, which I plan
> to push tomorrow.
>
> Patch 0001 needs to fix a batching specific function (or it won't
> compile) so there are separate versions for master and 19.
>
> For 0002, I am attaching only the patch that fixes the per-row fast
> path, which has the same shape in both master and 19. Nik had posted
> one patch to fix both paths, but I decided to break it into one patch
> that fixes the per-row path (which applies to both master and 19) and
> another that is only needed in master for fixing the batching path for
> the same opfamily change errors. I'm adding the latter to the list of
> patches I now have locally for fixing the various batching path issues
> I am aware of.

I have pushed 0001 and 0002 now and closed the open items.

--
Thanks, Amit Langote