| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Views no longer in rangeTabls? |
| Date: | 2023-06-14 05:34:56 |
| Message-ID: | CA+HiwqE-4AmfsmgX+nDSzi6+HzBO6WyLjjQhfxChn82YwAJO-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 14, 2023 at 12:08 Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Tue, Jun 13, 2023 at 9:40 PM David Steele <david(at)pgmasters(dot)net> wrote:
> > On 6/13/23 11:38, Amit Langote wrote:
> > > On Tue, Jun 13, 2023 at 6:33 PM Alvaro Herrera <
> alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > >> Note that you changed one comment from "permission checks" to
> > >> "permission hecks".
> > >
> > > Oops, thanks for pointing that out.
> > >
> > > Fixed in the attached.
> >
> > I have done another (more careful) review of the comments and I don't
> > see any other issues.
>
> Thanks for checking.
>
> Seeing no other comments, I've pushed this after rewriting the
> comments that needed to be changed to mention "relkind" right after
> "relid".
This being my first commit, I intently looked to check if everything’s set
up correctly. While it seemed to have hit gitweb and GitHub, it didn’t
pgsql-committers for some reason.
> --
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-06-14 05:40:18 | Re: remap the .text segment into huge pages at run time |
| Previous Message | Masahiko Sawada | 2023-06-14 05:08:59 | Re: make_ctags: use -I option to ignore pg_node_attr macro |