| From: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
|---|---|
| To: | solai v <solai(dot)cdac(at)gmail(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Available disk space per tablespace |
| Date: | 2026-07-17 06:38:35 |
| Message-ID: | CA+FpmFf26hv1Bu_CqMXyCReOSnhbS5pby-eLTgoZa4c3EEjGCg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 22 May 2026 at 11:46, solai v <solai(dot)cdac(at)gmail(dot)com> wrote:
> Hi ,
> I tested the v5 of the pg_tablespace_avail() patch on Linux.
> The patch applied and built cleanly for me .After applying the patch
> and re-running initdb,pg_tablespace_avail() worked correctly and \db+
> showed the new Free column as expected.
> The reported values matched the output from df -h on my system.I also
> tested custom tablespace and non-superuser access,and both behaved
> correctly.
> Additionally,I ran :
> make check TESTS= tablespace
> and all tests passed.
> Overall , the feature looks useful and worked well in my testing.
>
> Regards
> Solai
>
>
> I looked into this patch and here are my two cents, the change in
describe.c is in if (pset.sversion >= 190000), I think it should be
pset.sversion >= 200000 now, isn't it...?
Also, the first part of calculate_tablespace_avail and
calculate_tablespace_size are the same, would it make sense to have a
separate routine to have the acl check...?
--
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-07-17 06:44:19 | Re: sequencesync worker race with REFRESH SEQUENCES |
| Previous Message | Chao Li | 2026-07-17 05:37:02 | doc: clarify wal_sender_shutdown_timeout behavior for small values |