Re: Position of ClientAuthentication hook

From: Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Position of ClientAuthentication hook
Date: 2021-06-16 09:20:12
Message-ID: CA+FpmFep_mcHgO_yrsehFoJ+MOdBqMudurgA_vHWA_go9UHcRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 14 Jun 2021 at 21:04, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Jun 14, 2021 at 8:51 AM Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> wrote:
> > I have a doubt regarding the positioning of clientAuthentication hook
> > in function ClientAuthentication. Particularly, in case of hba errors,
> > i.e. cases uaReject or uaImplicitReject it errors out, leading to no
> > calls to any functions attached to the authentication hook. Can't we
> > process the hook function first and then error out...?
>
> Maybe. One potential problem is that if the hook errors out, the
> original error would be lost and only the error thrown by the hook
> would be logged or visible to the client. Whether or not that's a
> problem depends, I suppose, on what you're trying to do with the hook.

Thanks Robert for this quick clarification.

--
Regards,
Rafia Sabih

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Boris Kolpackov 2021-06-16 09:48:28 Pipeline mode and PQpipelineSync()
Previous Message Amit Kapila 2021-06-16 09:05:08 Re: Skipping logical replication transactions on subscriber side