| From: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: Emit message when batch_size is reduced |
| Date: | 2026-06-19 12:38:08 |
| Message-ID: | CA+FpmFeonsEEO6pMrUHnMa6bjOyw-Hku_sbGxn_d97ZCeWHH2w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 16 Jun 2026 at 22:20, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
> On Wed, Jun 10, 2026 at 5:09 AM Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>
> wrote:
>
>>
>>
>> On Tue, 9 Jun 2026 at 22:22, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
>> wrote:
>>
>>>
>>>> Thanks for your inputs. Reworked patch is attached.
>>>> --
>>>> Regards,
>>>> Rafia Sabih
>>>> CYBERTEC PostgreSQL International GmbH
>>>>
>>>
>>> You've addressed all my concerns, aside from the desire for the check on
>>> the set/update of the value. Do you have a commitfest entry? I didn't find
>>> one.
>>>
>> There is commitfest entry now -->
>> https://commitfest.postgresql.org/patch/6873/
>>
>>
>>
> I've added myself as a reviewer. Did you want to try adding the check at
> time of the option being set? If not, I can make an attempt at that.
>
Please find the attached file for the patch with the warning message at the
time of batch_size option addition. Looking forward to your inputs.
--
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Emit-debug-message-for-batch_size-reduced.patch | application/octet-stream | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Shetty | 2026-06-19 13:26:22 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | shveta malik | 2026-06-19 12:37:05 | Re: Proposal: Conflict log history table for Logical Replication |