| From: | Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | avoid false dropped replication slot log messages |
| Date: | 2026-05-09 02:47:58 |
| Message-ID: | CA+3i_M9OtBpysJctTKZs0q4NN=HAaaPuURTaoF+W+6205XfFgw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
If the shared-memory entry for a synced slot is concurrently reused by
a user-created slot in the small window between rm collecting the candidate
list and locking the database, drop_local_obsolete_slots() correctly
skips the drop but still emitted a LOG message claiming the slot had
been dropped, naming the unrelated user slot.
Gate the LOG message on the same synced_slot check that gates the drop,
and snapshot the slot name and database OID before calling
ReplicationSlotDropAcquired() so the message reflects what was actually
dropped
Regards,
Lakshmi
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-slotsync-avoid-false-dropped-replication-slot-log-me.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2026-05-09 02:51:44 | Adjust error message to reflect the inheritance relationship |
| Previous Message | Chao Li | 2026-05-09 02:01:08 | Re: Fix wrong error message from pg_get_tablespace_ddl() |