From: | Pravesh Sharma <pravesh(dot)sharma(at)enterprisedb(dot)com> |
---|---|
To: | Usman Khan <umk555(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Regarding issue #6510 |
Date: | 2025-05-21 04:34:20 |
Message-ID: | CA+36bxEwRMDowuJWWrx-NafLt5Zn1OELXOC__2PS2eeHkhqc5Q@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Usman,
The length is in the number of characters. So, if a user sets max length
500 then we will show data till 500 characters.
Thanks,
Pravesh
On Tue, May 20, 2025 at 9:08 PM Usman Khan <umk555(at)gmail(dot)com> wrote:
> Hi Pravesh,
> Nice idea from your side but my concern is:
>
> - If the user increases this limit to 1GB(which is a maximum size for
> a column in pg) through the *'Max column data display length'* option,
> will the function not break again?
>
>
> On Tue, May 20, 2025 at 10:16 AM Pravesh Sharma <
> pravesh(dot)sharma(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> I am working on issue #6510
>> <https://github.com/pgadmin-org/pgadmin4/issues/6510>, where the result
>> grid slows down and sometimes hangs when large JSON or text data is present
>> in a table column. Upon investigation, I found that this is due to
>> rendering the entire JSON to the DOM. This causes slowness, especially with
>> large datasets; for example, rendering a 15MB JSON object for preview
>> purposes is unnecessary. I am proposing a solution where the result grid
>> will render data up to a certain length. I have implemented these changes,
>> and everything is working fine, resulting in a significant performance
>> improvement. As you can see in the screenshot, the JSON data is 20MB, and
>> on the result grid, we are displaying only 200 characters as it is only a
>> preview. I am also considering making this maximum display length a user
>> preference, named "Max column data display length," allowing them to
>> customize how much data they want to see. Can you tell me what you think of
>> this approach or if you have any suggestions?
>>
>>
>> Thanks,
>>
>> Pravesh
>>
>> [image: image.png]
>> --
>>
>>
>> Pravesh Sharma
>>
>> Senior SDE
>>
>> +91 9406461406
>>
>>
>> enterprisedb.com
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Pravesh Sharma | 2025-05-21 04:35:33 | Re: Regarding issue #6510 |
Previous Message | Zaid Shabbir | 2025-05-20 15:49:29 | Re: Regarding issue #6510 |