| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: New test function replace_conf() to get rid of unlink/append pattern |
| Date: | 2026-10-22 10:07:41 |
| Message-ID: | C9EADB50-39BB-4B8C-BF31-C64CE938801A@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Oct 2026, at 21:15, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> Thanks for the patch! It makes sense to me to have this function, makes
> the tests easier to follow.
Thanks for review!
> Small nit on the replace vs rewrite thing you mentioned: should we change
> the below comment too to use "replacing"?
Fixed.
> Also, I noticed the forked-backend SKIP block in
> src/test/ssl/t/004_sni.pl still skips 11 tests. Since we're removing the
> ok(unlink(...)) assertion, ig that should be 10 now.
Right. The skip number isn't actually used for no_plan plans which we use so
the number isn't particularly useful, but since we do specify it the number
should match so: Fixed.
> On 13 Oct 2026, at 10:30, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> LGTM. We might add these as well:
>
> diff --git a/src/test/ssl/t/SSL/Server.pm b/src/test/ssl/t/SSL/Server.pm
Ah, good catch, fixed.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-replace_conf-test-utility-function.patch | application/octet-stream | 29.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ZizhuanLiu X-MAN | 2026-10-22 10:42:49 | Optimize mergejoinscansel() by avoiding redundant computations |
| Previous Message | Daniel Gustafsson | 2026-10-22 09:52:06 | Re: Continuous re-validation of session credentials |