| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2016-02-12 16:39:05 |
| Message-ID: | C97ED02B-079B-4974-8572-57334145F8CD@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On February 12, 2016 5:29:44 PM GMT+01:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> We should standardize on the "((var & FLAG) != 0)"
>pattern, which works reliably in all cases.
That's what the second version of my patch, and I presume Michael's updated one as well, does. I think the only open question is how far to backpatch. While annoying work, I think we should go all the way.
Andres
---
Please excuse brevity and formatting - I am writing this on my mobile phone.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yury Zhuravlev | 2016-02-12 16:40:29 | Re: GinPageIs* don't actually return a boolean |
| Previous Message | Pavel Stehule | 2016-02-12 16:35:58 | Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring. |