| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | solai v <solai(dot)cdac(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Viktor Holmberg <v(at)viktorh(dot)net>, Vik Fearing <vik(at)postgresfriends(dot)org>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values |
| Date: | 2026-09-01 18:49:41 |
| Message-ID: | C93A96B3-B03E-4A8D-8FF3-23602C2C18E3@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I reviewed v6 too. The parser, rewriter, planner and executor changes
look correct to me. I also checked mixed conflict/non-conflict rows,
correlated subqueries, view-expression rewriting and column-level
privileges.
I agree that allowing unqualified column names in ON CONFLICT SET and
WHERE should be a separate change. This patch does not depend on it.
There are two small typos: "espectively" in setrefs.c, and Viktor's
previously reported "EXLCUDED" in returning.sql and returning.out.
Neither needs another patch revision.
I think this[0] is ready for committer. I'll flip the status.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-09-01 18:50:23 | Re: Error handling in after-startup shmem requests |
| Previous Message | Matthias van de Meent | 2026-09-01 18:42:22 | Re: Reducing relcache memory usage: deduping index shapes |