| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joe Conway <joe(at)crunchydata(dot)com> |
| Subject: | Re: Granting SET and ALTER SYSTE privileges for GUCs |
| Date: | 2022-01-31 19:17:12 |
| Message-ID: | C8DF19D8-C15D-4C2D-91CA-391390F1E421@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 26, 2022, at 7:24 AM, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
> Rebased:
>
> <v7-0001-Allow-GRANT-of-SET-and-ALTER-SYSTEM-SET-for-gucs.patch>
Hackers,
Joshua and I had some off-list back-and-forth on this patch and I think the attached v8 patch meets his needs. Specifically, v8 adds support for object access hooks in the case of SET and ALTER SYSTEM SET of a guc variable.
The way InvokeObjectPostAlterHookArg() is written, it expects some things like a Oid that we don't always have. I abused the parameters of that function to pass as much information as possible. Anyone wanting to review this might consider how that is coded.
Joshua, this is byte-for-byte the same patch that you already reviewed off-list (or I attached the wrong patch!) If you are satisfied, could you set the status to ready-for-committer?
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Allow-GRANT-of-SET-and-ALTER-SYSTEM-SET-for-gucs.patch | application/octet-stream | 208.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2022-01-31 19:55:56 | Re: CREATEROLE and role ownership hierarchies |
| Previous Message | Simon Riggs | 2022-01-31 19:11:39 | Re: PITR: enhance getRecordTimestamp() |