Re: [PATCH] Cross-reference comments on signal handling logic

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Cross-reference comments on signal handling logic
Date: 2021-09-27 12:21:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 1 Mar 2021, at 19:22, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:

>> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> wrote:
>> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
> In src/backend/postmaster/interrupt.c:
> + * These handlers are NOT used by normal user backends as they do not support
> vs.
> + * Most backends use this handler.
> These two comments seem to contradict. If interrupt.c contains handlers that normal user backends to not use, then how can it be that most backends use one of the handlers in the file?

I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests. Please reopen in a future
commitfest if you still would like to pursue this patch.

Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-09-27 12:23:49 Re: Column Filtering in Logical Replication
Previous Message Aleksander Alekseev 2021-09-27 11:59:22 Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]