| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Should vacuum process config file reload more often |
| Date: | 2023-04-27 09:32:29 |
| Message-ID: | C6068C97-1998-459B-B6A7-C6A71D1CE443@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Apr 2023, at 11:29, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > I had another read-through and test-through of this version, and have applied
> > it with some minor changes to comments and whitespace. Thanks for the quick
> > turnaround times on reviews in this thread!
>
> - VacuumFailsafeActive = false;
> + Assert(!VacuumFailsafeActive);
>
> I can trigger this assert added in commit 7d71d3dd08.
>
> First build with the patch in [1], then:
Interesting, thanks for the report! I'll look into it directly.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yu Shi (Fujitsu) | 2023-04-27 09:41:22 | RE: Fix a test case in 035_standby_logical_decoding.pl |
| Previous Message | John Naylor | 2023-04-27 09:29:49 | Re: Should vacuum process config file reload more often |