Re: initdb caching during tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: initdb caching during tests
Date: 2023-08-23 08:10:31
Message-ID: C47F1E11-A85B-4B1E-9025-C0974CBD9E94@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 23 Aug 2023, at 03:17, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote:

>> My only small gripe is that I keep thinking about template databases for CREATE
>> DATABASE when reading the error messages in this patch, which is clearly not
>> related to what this does.
>>
>> + note("initializing database system by copying initdb template");
>>
>> I personally would've used cache instead of template in the user facing parts
>> to keep concepts separated, but thats personal taste.
>
> I am going back and forth on that one (as one can notice with $subject). It
> doesn't quite seem like a cache, as it's not "created" on demand and only
> usable when the exactly same parameters are used repeatedly. But template is
> overloaded as you say...

That's a fair point, cache is not a good word to describe a stored copy of
something prefabricated. Let's go with template, we can always refine in-tree
if a better wording comes along.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2023-08-23 08:20:23 Re: MERGE ... RETURNING
Previous Message Alvaro Herrera 2023-08-23 08:00:56 Re: subscription/015_stream sometimes breaks