Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)
Date: 2022-02-17 12:48:12
Message-ID: C3BE49B2-5FA7-428D-9913-3AA849CF5FBF@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 Feb 2022, at 13:19, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:

> 1. One #ifdef with a mistake, the correct is _WIN32 and not WIN32.

Can you elaborate on this, we are using WIN32 pretty extensively in the code:

$ git grep "if[n]\{0,1\}def WIN32$"|wc -l
511
$ git grep "if[n]\{0,1\}def _WIN32$"|wc -l
2

The _WIN32 cases are in the same ECPG testcase.

Why would _WIN32 be correct in this case?

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2022-02-17 12:59:10 Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)
Previous Message Ranier Vilela 2022-02-17 12:35:06 [PATCH] Fix possible minor memory leak (src/backend/catalog/heap.c)