Re: Interval input: usec, msec

From: Michael Glaesemann <grzm(at)seespotcode(dot)net>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Interval input: usec, msec
Date: 2007-05-29 12:49:49
Message-ID: C2B8FF34-2462-4DA2-8AC8-DC4E2DDDD976@seespotcode.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-patches


On May 29, 2007, at 0:06 , Neil Conway wrote:

> Applied to HEAD, backported to 8.2 and 8.1

One thing I noticed when looking over the patch is that there are a
few bare numbers in datetime.c such as 100000, 1000, 1e-3, and 1e-6.
In timestamp.[hc] we've defined macros for conversions such as
#define #define USECS_PER_SEC INT64CONST(1000000)

I'd like to work up a patch that would add similar macros for
datetime.c, in particular using the INT64CONST construction where
appropriate. Thoughts?

Michael Glaesemann
grzm seespotcode net

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Zdenek Kotala 2007-05-29 13:55:27 Re: [pgsql-patches] Ctid chain following enhancement
Previous Message Les Hill 2007-05-29 12:31:58 OS X startup script patch