| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> | 
|---|---|
| To: | Sam Mason <sam(at)samason(dot)me(dot)uk> | 
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-general(at)postgresql(dot)org | 
| Subject: | Re: [HACKERS] string_to_array with empty input | 
| Date: | 2009-04-02 19:06:01 | 
| Message-ID: | C2B2DAB5-E4C2-4D65-B236-822CEEF7ABC5@kineticode.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-general pgsql-hackers | 
On Apr 2, 2009, at 11:24 AM, Sam Mason wrote:
> Yes, I'd be tempted to pick one and go with it.  It's seems a  
> completely
> arbitrary choice one way or the other but the current behaviour is
> certainly wrong.
>
> I'd go with returning a zero element array because it would do
> the "right thing" more often when paired with array_to_string.
> I've also been through the first few pages of a Google search for
> "array_to_string" and it seems to do the "right" thing for the  
> majority
> of the cases.
Forgive me if I'm missing something, but it seems to me that  
array_to_string() works either way, no?
try=# select '"' || array_to_string('{}'::text[], ',') || '"'; ?column?
----------
  ""
(1 row)
Time: 72.129 ms
try=# select '"' || array_to_string('{""}'::text[], ',') || '"';
  ?column?
----------
  ""
(1 row)
Best,
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrej | 2009-04-02 19:10:59 | Re: Postgresql installation with ssh connection. | 
| Previous Message | dfx | 2009-04-02 18:51:51 | Postgresql installation with ssh connection. | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2009-04-02 19:13:02 | Re: Crash in gist insertion on pathological box data | 
| Previous Message | Bruce Momjian | 2009-04-02 19:03:08 | Re: Additional DTrace Probes |