| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix locking issue with fixed-size stats template in injection_points |
| Date: | 2025-09-29 07:29:25 |
| Message-ID: | C27B79E2-4F59-4292-99C9-B0C169F595E8@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 29, 2025, at 14:27, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Sep 29, 2025 at 09:46:05AM +0800, Chao Li wrote:
>> I saw pg_state_begin_changecount_write() is called multiple places,
>> as you mention, for example bgwriter.
>
> I've mentioned that in my first email, and put in details:
> - pgstat_report_bgwriter() is called once, by the bgwriter.
> - pgstat_report_checkpointer() is called three time, all by the
> checkpointer.
> - pgstat_report_archiver() is called twice, all by pgarch.c.
>
> So all of them don't have a problem, two calls cannot happen
> concurrently.
> --
> Michael
Thanks for the clarification. Then the patch looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-09-29 07:42:39 | Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation |
| Previous Message | Ashutosh Bapat | 2025-09-29 07:24:24 | Re: Report bytes and transactions actually sent downtream |