Re: GIN pageinspect support for entry tree and posting tree

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Subject: Re: GIN pageinspect support for entry tree and posting tree
Date: 2026-01-03 18:57:56
Message-ID: C26BE268-A4B2-43B7-8145-0F8E1DEFA21D@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Jan 2026, at 00:16, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> PFA v4 with typo fixes.

Thanks!

I think block size dependency is not a problem. There are no pageinspect tests that pass with 1Kb pages.

I have some more nits:

Meson build needs to be updated.

Documentation is on a TODO list.

+ relation_close(indexRel, AccessShareLock);
Perhaps, index_close() is what you actually wanted?

StringInfoData buf is leaked still, you can init it once and reset in the loop.

tmpTupdesc recreation worth commenting on.

Thanks!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2026-01-03 19:09:00 Re: Parallelizing startup with many databases
Previous Message Andreas Karlsson 2026-01-03 18:44:44 Re: not fully correct error message