| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Zaorang Yang <zaorangy(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix typo in comment |
| Date: | 2022-05-06 12:58:46 |
| Message-ID: | C09888E5-1462-429D-8BCE-B4256FA18436@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 May 2022, at 14:50, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-May-06, Zaorang Yang wrote:
>
>> Maybe, the first letter of comments in postinit.c should be capitalized.
>
> Hmm, typically these one-line comments are not "full sentences", so they
> don't have capitals and no ending periods either. I wouldn't like the
> endless stream of patches that would result if we let this go in.
Agreed. A quick grep turns up a fair number of such comments:
$ git grep "^\s*\/\* [a-z].\+\*\/$" src/ | wc -l
16588
If anything should be done to this it would perhaps be better to add to
pgindent or a similar automated process. If anything.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2022-05-06 13:19:43 | Trying to add more tests to gistbuild.c |
| Previous Message | Alvaro Herrera | 2022-05-06 12:50:11 | Re: Fix typo in comment |