Re: [bug fix] "pg_ctl stop" times out when it should respond quickly

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] "pg_ctl stop" times out when it should respond quickly
Date: 2013-12-25 11:40:18
Message-ID: C00418B3257A49009F30B7AFF8EDE1B7@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Peter Eisentraut" <peter_e(at)gmx(dot)net>
> This patch breaks the regression tests:
>
> xml ... ok
> test stats ... ok
> ============== shutting down postmaster ==============
> <waits a long time>
> pg_ctl: server does not shut down
>
> pg_regress: could not stop postmaster: exit code was 256

pg_ctl timed out waiting for the zombie postgres.

maumau 19621 18849 0 15:21 pts/9 00:00:00 [postgres] <defunct>
maumau 20253 18849 0 15:22 pts/9 00:00:00
/maumau/postgresql-9.4/src/test/regress/./tmp_check/install//maumau/pgsql/bin/pg_ctl
stop -D /maumau/postgresql-9.4/src/test/regress/./tmp_check/data -s -m fast

pg_regress must wait for postgres to terminate by calling waitpid(), because
it invoked postgres directly. The attached pg_regress_pg_stop.patch does
this. If you like the combination of this and the original fix for pg_ctl
in one patch, please use pg_stop_fail_v3.patch.

Sorry for causing trouble.

Regards
MauMau

Attachment Content-Type Size
pg_stop_fail_v3.patch application/octet-stream 2.6 KB
pg_regress_pg_stop.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Joseph Krogh 2013-12-25 12:01:03 BDR-project
Previous Message Craig Ringer 2013-12-25 09:23:07 Re: varattno remapping