Re: Concurrent deadlock scenario with DROP INDEX on partitioned index

From: Jimmy Yih <jyih(at)vmware(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Gaurab Dey <gaurabd(at)vmware(dot)com>
Subject: Re: Concurrent deadlock scenario with DROP INDEX on partitioned index
Date: 2022-03-16 20:43:12
Message-ID: BYAPR05MB6454551BCCF049ADAE65A157BD119@BYAPR05MB6454.namprd05.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Hi,
> For RangeVarCallbackForDropRelation():
>
> + LockRelationOid(indexRelationOid, heap_lockmode);
>
> Since the above is called for both if and else blocks, it can be lifted outside.

Thanks for the feedback. Attached new v3 patch with feedback addressed.

--
Jimmy Yih (VMware)
Gaurab Dey (VMware)

Attachment Content-Type Size
v3-0001-Fix-concurrent-deadlock-scenario-with-DROP-INDEX-.patch application/octet-stream 11.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2022-03-16 20:49:55 Re: Proposal: Support custom authentication methods using hooks
Previous Message Alvaro Herrera 2022-03-16 20:36:02 Re: support for MERGE