| From: | Steve Singer <steve(at)ssinger(dot)info> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 9.4 logical replication - walsender keepalive replies |
| Date: | 2014-07-14 17:19:11 |
| Message-ID: | BLU436-SMTP88ADA2989C872F31AE7AEEDC0A0@phx.gbl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/06/2014 10:11 AM, Andres Freund wrote:
> Hi Steve,
> Right. I thought about this for a while, and I think we should change
> two things. For one, don't request replies here. It's simply not needed,
> as this isn't dealing with timeouts. For another don't just check ->flush
> < sentPtr but also && ->write < sentPtr. The reason we're sending these
> feedback messages is to inform the 'logical standby' that there's been
> WAL activity which it can't see because they don't correspond to
> anything that's logically decoded (e.g. vacuum stuff).
> Would that suit your needs?
>
> Greetings,
Yes I think that will work for me.
I tested with the attached patch that I think does what you describe
and it seems okay.
> Andres Freund
>
| Attachment | Content-Type | Size |
|---|---|---|
| walsender_response.diff | text/x-patch | 900 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2014-07-14 17:23:56 | Re: Pg_upgrade and toast tables bug discovered |
| Previous Message | Andres Freund | 2014-07-14 16:19:42 | Re: things I learned from working on memory allocation |