Re: Two division by 0 errors in optimizer/plan/planner.c and optimizer/path/costsize.c

From: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Two division by 0 errors in optimizer/plan/planner.c and optimizer/path/costsize.c
Date: 2016-03-28 11:48:12
Message-ID: BLU436-SMTP23165BE086370EFD7A9A585F2860@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-03-28 11:33, Aleksander Alekseev wrote:
> Hello, Piotr.
>
> Thanks for report. But I'm having some difficulties reproducing issues
> you described.

Oh, if you want backtraces then either set a conditional breakpoint or
add your own Assert like I did.

> Also it would be a good idea to include these steps to regression tests.

I agree and I generally think that the more test cases touch previously
not covered code paths the better, even if it had to be run as a
different make(1) target. Although it seems that at least some people
would agree (see [1]), the "make check" split somehow isn't happening.

[1] CA+TgmoYMOFE94+3WG3spg9sqAjkv4siXjey+RDrMAMyE-VqsEw(at)mail(dot)gmail(dot)com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-03-28 12:46:08 Re: Relation extension scalability
Previous Message Alexander Korotkov 2016-03-28 11:45:32 Re: WIP: Access method extendability