Re: [PATCH] Fix conversion for Decimal arguments in plpython functions

From: Steve Singer <steve(at)ssinger(dot)info>
To: Szymon Guz <mabewlun(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Ronan Dunklau <rdunklau(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix conversion for Decimal arguments in plpython functions
Date: 2013-06-28 20:14:04
Message-ID: BLU0-SMTP68323457DEFD9CF0B81500DC760@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 06/27/2013 05:04 AM, Szymon Guz wrote:
> On 27 June 2013 05:21, Steve Singer <steve(at)ssinger(dot)info
> <mailto:steve(at)ssinger(dot)info>> wrote:
> On 06/26/2013 04:47 PM, Szymon Guz wrote:
> Hi Steve,
> thanks for the changes.
> You're idea about common code for decimal and cdecimal is good,
> however not good enough. I like the idea of common code for decimal
> and cdecimal. But we need class name, not the value.
> I've changed the code from str(x) to x.__class__.__name__ so the
> function prints class name (which is Decimal for both packages), not
> the value. We need to have the class name check. The value is returned
> by the function and is a couple of lines lower in the file.
> patch is attached.

I think the value is more important than the name, I want to the tests
to make sure that the conversion is actually converting properly. With
your method of getting the class name without the module we can have both.

The attached patch should print the value and the class name but not the
module name.


> thanks,
> Szymon

Attachment Content-Type Size
plpython_decimal_v8.patch text/x-patch 12.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2013-06-28 20:22:52 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]
Previous Message Josh Berkus 2013-06-28 19:58:43 Re: Add more regression tests for ASYNC