| From: | "Amonson, Paul D" <paul(dot)d(dot)amonson(at)intel(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Matthias van de Meent" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Popcount optimization using AVX512 |
| Date: | 2024-03-19 22:56:01 |
| Message-ID: | BL1PR11MB530414B036FD7E838830E398DC2C2@BL1PR11MB5304.namprd11.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> -----Original Message-----
> From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
>
> Committed. Thanks for the suggestion and for reviewing!
>
> Paul, I suspect your patches will need to be rebased after commit cc4826d.
> Would you mind doing so?
Changed in this patch set.
* Rebased.
* Direct *slow* calls via macros as shown in example patch.
* Changed the choose filename to be platform specific as suggested.
* Falls back to intermediate "Fast" methods if AVX512 is not available at runtime.
* inline used where is makes sense, remember using "extern" negates "inline".
* Fixed comment issues pointed out in review.
I tested building with and without TRY_POPCOUNT_FAST, for both configure and meson build systems, and ran in CI.
Thanks,
Paul
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Refactor-inlining-and-direct-calls-for-_slow-functio.patch | application/octet-stream | 7.9 KB |
| v10-0002-Refactor-Seperated-slow-fast-and-choose-functionalit.patch | application/octet-stream | 15.8 KB |
| v10-0003-Feature-Add-POPCNT512-accelerated-functionality-for-.patch | application/octet-stream | 23.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-03-19 23:09:14 | Re: Partial aggregates pushdown |
| Previous Message | Tom Lane | 2024-03-19 22:35:27 | Re: Possibility to disable `ALTER SYSTEM` |