| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Explain what the default output_plugin_libraries do |
| Date: | 2026-09-22 06:08:29 |
| Message-ID: | BFD7E925-B4A6-4DE0-AD04-BB3A47089628@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 22, 2026, at 06:45, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Mon, Sep 21, 2026 at 9:02 AM Jacob Champion
> <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>>
>>>> Okay. Any thoughts on Bharath's note on "publication slot creation" above?
>>>
>>> I could not find the term "publication slot" in the existing doc, so I prefer
>>> his idea. Another one I came up with to just simplify:
>>>
>>> ```
>>> Removing from output_plugin_libraries will cause future logical replication to
>>> fail with an error. (Beware that existing replication tools may not degrade gracefully
>>> if the server is configured in this way.)
>>
>> But only built-in logical replication will fail. How about
>>
>> Core plugin for logical replication. Removing
>> <literal>pgoutput</literal>
>> from <literal>output_plugin_libraries</literal> will cause future
>> subscription connections, and maintenance of the replication slots
>> for subscriptions, to fail with an error. (Beware that ...
>>
>> ?
>
> This part works for me. Thanks.
>
This also looks good to me.
I have the other nitpick:
```
<productname>PostgreSQL</productname> distribution.
+ (<xref linkend="guc-output-plugin-libraries-builtins"/> documents the
+ behavior of the system if they are removed from this list.)
</para>
```
I tried to build the HTML page, and see that <xref linkend="guc-output-plugin-libraries-builtins”/> is rendered as “Table 19.2”, so it looks like “(Table 19.2 documents ….)”, which looks a little awkward. How about not using parentheses, and just say something like: See <xref linkend="guc-output-plugin-libraries-builtins"/> for the effects of removing these plugins from the list.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2026-09-22 06:32:16 | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |
| Previous Message | Peter Eisentraut | 2026-09-22 05:28:05 | Re: Add counted_by attribute |