| From: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
|---|---|
| To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Cc: | Jerry LeVan <jerry(dot)levan(at)eku(dot)edu> |
| Subject: | 1.4.1 On OSX |
| Date: | 2005-12-21 10:21:46 |
| Message-ID: | BFCEDD3C.81B0%dpage@vale-housing.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Andreas,
I finally tracked down the bug in 1.4.1 on Mac which causes a crash whenever
pretty much any property dialogue is opened. Basically, in
ctlComboBox::GetSelection() we call GetCurrentSelection(). In wxMac however,
this simply calls GetSelection() which is a virtual and results in our
GetSelection() actually getting called, in turn causing a loop and eventual
stack overflow.
So, the attached patch seems to fix the problem and return the auto-complete
code to the same slightly-broken-but-usable state that it was in 1.4.0 (i.e,
you can only type the first character of a data type for example, and the
first match will be selected).
Can you take a look and confirm my analysis (or call me an idiot, whatever
is correct!) before I apply this to both branches and packare 1.4.1.plus
please?
Regards, Dave
| Attachment | Content-Type | Size |
|---|---|---|
| mac_combobox_fix.diff | application/octet-stream | 421 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | svn | 2005-12-21 13:11:04 | SVN Commit by andreas: r4850 - trunk/pgadmin3/src/include/ctl |
| Previous Message | Devrim GUNDUZ | 2005-12-21 10:19:32 | Re: IRC Channel @ FreeNode |