Re: Parallel Seq Scan

On 25 March 2015 16:00, Amit Kapila Wrote:

> Which version of patch you are looking at?
> I am seeing below code in ExecInitFunnel() in Version-11 to which
> you have replied.

> + /* Funnel node doesn't have innerPlan node. */
> + Assert(innerPlan(node) == NULL

I was seeing the version-10.
I just checked version-11 and version-12 and found to be already fixed.
I should have checked the latest version before sending the report…☺

Thanks and Regards,
Kumar Rajeev Rastogi

From: Amit Kapila [mailto:amit(dot)kapila16(at)gmail(dot)com]
Sent: 25 March 2015 16:00
To: Rajeev rastogi
Cc: Amit Langote; Robert Haas; Andres Freund; Kouhei Kaigai; Amit Langote; Fabrízio Mello; Thom Brown; Stephen Frost; pgsql-hackers
Subject: Re: [HACKERS] Parallel Seq Scan

On Wed, Mar 25, 2015 at 3:47 PM, Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com<mailto:rajeev(dot)rastogi(at)huawei(dot)com>> wrote:
>
> On 20 March 2015 17:37, Amit Kapila Wrote:
>

> > So the patches have to be applied in below sequence:

> > HEAD Commit-id : 8d1f2390
> > parallel-mode-v8.1.patch [2]
> > assess-parallel-safety-v4.patch [1]
> > parallel-heap-scan.patch [3]
> > parallel_seqscan_v11.patch (Attached with this mail)

>
> While I was going through this patch, I observed one invalid ASSERT in the function “ExecInitFunnel” i.e.
>
> Assert(outerPlan(node) == NULL);
>
> Outer node of Funnel node is always non-NULL and currently it will be PartialSeqScan Node.
>
Which version of patch you are looking at?

I am seeing below code in ExecInitFunnel() in Version-11 to which
you have replied.

+ /* Funnel node doesn't have innerPlan node. */
+ Assert(innerPlan(node) == NULL);

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com<http://www.enterprisedb.com/>