Re: [dsm] comment typo

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [dsm] comment typo
Date: 2023-08-21 09:16:21
Message-ID: BEA51526-2354-44F6-AD40-31AD16AA3790@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 18 Aug 2023, at 11:10, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> In the following sentence, I believe either 'the' or 'a' should be kept, not
> both. I here keep the 'the', but feel free to change.

> * handle: The handle of an existing object, or for DSM_OP_CREATE, the
> - * a new handle the caller wants created.
> + * new handle the caller wants created.

Since the handle doesn't exist for DSM_OP_CREATE, both "a handle" and "the
handle" seems a tad misleading, how about "the identifier for the new handle the
caller wants created"?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xiang Gao 2023-08-21 09:32:42 Optimize Arm64 crc32 implementation in PostgreSQL
Previous Message Andrey M. Borodin 2023-08-21 08:42:20 Re: UUID v7